Updated ocr3 Metadata type to include Encoding and Decoding #1160
+698
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silaslenihan
temporarily deployed
to
integration
GitHub Actions
Inactive
silaslenihan
temporarily deployed
to
integration
GitHub Actions
Inactive
silaslenihan
had a problem deploying
to
integration
GitHub Actions
Failure
silaslenihan
had a problem deploying
to
integration
GitHub Actions
Failure
silaslenihan
temporarily deployed
to
integration
GitHub Actions
Inactive
silaslenihan
temporarily deployed
to
integration
GitHub Actions
Inactive
silaslenihan
had a problem deploying
to
integration
GitHub Actions
Failure
silaslenihan
had a problem deploying
to
integration
GitHub Actions
Failure
silaslenihan
had a problem deploying
to
integration
GitHub Actions
Failure
silaslenihan
had a problem deploying
to
integration
GitHub Actions
Failure
silaslenihan
had a problem deploying
to
integration
GitHub Actions
Failure
This was referenced May 14, 2025
silaslenihan
had a problem deploying
to
integration
GitHub Actions
Failure
krebernisak
reviewed
May 23, 2025
krebernisak
reviewed
May 23, 2025
silaslenihan
had a problem deploying
to
integration
GitHub Actions
Failure
silaslenihan
had a problem deploying
to
integration
GitHub Actions
Failure
silaslenihan
had a problem deploying
to
integration
GitHub Actions
Failure
silaslenihan
force-pushed
the
update-ocr3-metadata
branch
from
15fe47d to
5ca7af8
Compare
silaslenihan
had a problem deploying
to
integration
GitHub Actions
Failure
silaslenihan
had a problem deploying
to
integration
GitHub Actions
Failure
jmank88
reviewed
May 27, 2025
| return buf.Bytes(), nil | ||
| } | ||
|
|
||
| const MetadataLen = 1 + 32 + 4 + 4 + 4 + 32 + 10 + 20 + 2 // =109 |
There was a problem hiding this comment.
Maybe worth repeating these details here 🤷
Suggested change
| const MetadataLen = 1 + 32 + 4 + 4 + 4 + 32 + 10 + 20 + 2 // =109 | |
| // 1B Version, 32B ExecutionID, 4B Timestamp, 4B DONID, 4B DONConfigVersion, | |
| // 32B WorkflowID, 10B WorkflowName, 20B WorkflowOwner, 2B ReportID | |
| const MetadataLen = 1 + 32 + 4 + 4 + 4 + 32 + 10 + 20 + 2 // =109 |
jmank88
reviewed
May 27, 2025
| } | ||
|
|
||
| // appendAttrsRequired appends required attributes to the attribute key-value list | ||
| func (e *protoEmitter) appendAttrsRequired(ctx context.Context, m proto.Message, attrKVs []any) []any { |
There was a problem hiding this comment.
Context is unused
Suggested change
| func (e *protoEmitter) appendAttrsRequired(ctx context.Context, m proto.Message, attrKVs []any) []any { | |
| func (e *protoEmitter) appendAttrsRequired(m proto.Message, attrKVs []any) []any { |
jmank88
reviewed
May 27, 2025
Comment on lines
+93
to
+94
| attrKVs = appendRequiredAttrEntity(m, attrKVs) | ||
| attrKVs = appendRequiredAttrDomain(m, attrKVs) |
There was a problem hiding this comment.
Why don't we align with the build in append func, by passing attrKVs as the first argument?
Suggested change
| attrKVs = appendRequiredAttrEntity(m, attrKVs) | |
| attrKVs = appendRequiredAttrDomain(m, attrKVs) | |
| attrKVs = appendRequiredAttrEntity(attrKVs, m) | |
| attrKVs = appendRequiredAttrDomain(attrKVs, m) |
jmank88
reviewed
May 27, 2025
Comment on lines
+69
to
+70
| // Needs to be an URI (Beholder requirement) | ||
| val := toSchemaPath(m, basePath) |
There was a problem hiding this comment.
Do we need to be doing this for the caller? This is the only use of m and basePath, so we could just accept the val as a parameter, which is more flexible/reusable.
jmank88
reviewed
May 27, 2025
Comment on lines
+92
to
+96
| for i := 0; i < len(attrKVs); i += 2 { | ||
| if attrKVs[i] == key { | ||
| return attrKVs | ||
| } | ||
| } |
There was a problem hiding this comment.
Let's make some kind of helper for this repeated block:
Suggested change
| for i := 0; i < len(attrKVs); i += 2 { | |
| if attrKVs[i] == key { | |
| return attrKVs | |
| } | |
| } | |
| if containsKey(attrKVs, key) { | |
| return attrKVs | |
| } |
func containsKey(attrKVs []any, key string) bool {
for i := 0; i < len(attrKVs); i += 2 {
if attrKVs[i] == key {
return true
}
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires
Supports